Simplify DisconnectBlock arguments/return value
commitdb994b2de93f52c9e7bed8529ca925de5064a46f
authorPieter Wuille <pieter.wuille@gmail.com>
Fri, 28 Apr 2017 23:08:39 +0000 (28 16:08 -0700)
committerPieter Wuille <pieter.wuille@gmail.com>
Fri, 28 Apr 2017 23:15:01 +0000 (28 16:15 -0700)
tree37d6a59445bc81c6652afd4e162e66ab0db8793b
parent4c924011f535c46b3bc02bef8b7e2a8ad559d78d
Simplify DisconnectBlock arguments/return value

DisconnectBlock currently has a complicated interface:

  Situation       Return value
                  pfClean != nullptr   pfClean == nullptr

  All good:       true                 true
  Failure:        false                false
  Unclean rewind: true                 false
                  with *pfClean=false

Change this to return a tristate enum instead. As an added bonus,
remove the ValidationState& argument which was unused.
src/validation.cpp