| commit | ccf84bb9c10b4397f1a2aed6cf83fa0172c5cf7f | |
| author | Russell Yanofsky <russ@yanofsky.org> | |
| Thu, 2 Mar 2017 21:14:39 +0000 (2 16:14 -0500) | ||
| committer | Russell Yanofsky <russ@yanofsky.org> | |
| Mon, 5 Jun 2017 14:59:58 +0000 (5 09:59 -0500) | ||
| tree | 2d463e44174e21d1d741059a926941f56ea42117 | treesnapshot (tar.gz zip) |
| parent | e654d61d94ee11bb363964a827cab9738a6cedca | commitdiff |
Move birthday optimization out of ScanForWalletTransactions
This change has no effect on wallet behavior.
On wallet startup, the transaction scan avoids reading any blocks with
timestamps older than the wallet birthday (less than nTimeFirstKey -
TIMESTAMP_WINDOW). This block skipping code currently resides in
CWallet::ScanForWalletTransactions but it doesn't really belong there because
it makes the implementation unnecessarily fragile and hard to understand, and
it never has any effect except at startup (because all other callers do their
rescans based on timestamps other than, but always greater or equal to,
nTimeFirstKey).
This change has no effect on wallet behavior.
On wallet startup, the transaction scan avoids reading any blocks with
timestamps older than the wallet birthday (less than nTimeFirstKey -
TIMESTAMP_WINDOW). This block skipping code currently resides in
CWallet::ScanForWalletTransactions but it doesn't really belong there because
it makes the implementation unnecessarily fragile and hard to understand, and
it never has any effect except at startup (because all other callers do their
rescans based on timestamps other than, but always greater or equal to,
nTimeFirstKey).
| src/wallet/wallet.cpp | diffblobblamehistory |