| commit | ae47724687a78572daba5bc113d99d03b7ab01d6 | |
| author | Jonas Schnelli <dev@jonasschnelli.ch> | |
| Tue, 15 Aug 2017 19:24:07 +0000 (15 21:24 +0200) | ||
| committer | Jonas Schnelli <dev@jonasschnelli.ch> | |
| Tue, 15 Aug 2017 19:24:21 +0000 (15 21:24 +0200) | ||
| tree | 349cd17838893086998b7d96c79d874f8e6d124f | treesnapshot (tar.gz zip) |
| parent | 64e66bb2628820903e6ca1074a1805b305c4565e | commitdiff |
| parent | 03bc719a85cb4928cb4b43d0bc4142f72cb01b23 | commitdiff |
Merge #11017: [wallet] Close DB on error.
03bc719a8 [wallet] Close DB on error. (Karl-Johan Alm)
Pull request description:
This PR intends to plug some leaks. It specifically implements adherence to the requirement in BDB to close a handle which failed to open (https://docs.oracle.com/cd/E17276_01/html/api_reference/C/dbopen.html):
> The `DB->open()` method returns a non-zero error value on failure and 0 on success. If `DB->open()` fails, the `DB->close()` method must be called to discard the DB handle.
Tree-SHA512: cc1f2b925ef3fd6de785f62108fbc79454443397f80707762acbc56757841d2c32b69c0234f87805571aa40c486da31f315ca4c607a2c7d1c97c82a01301e2a6
03bc719a8 [wallet] Close DB on error. (Karl-Johan Alm)
Pull request description:
This PR intends to plug some leaks. It specifically implements adherence to the requirement in BDB to close a handle which failed to open (https://docs.oracle.com/cd/E17276_01/html/api_reference/C/dbopen.html):
> The `DB->open()` method returns a non-zero error value on failure and 0 on success. If `DB->open()` fails, the `DB->close()` method must be called to discard the DB handle.
Tree-SHA512: cc1f2b925ef3fd6de785f62108fbc79454443397f80707762acbc56757841d2c32b69c0234f87805571aa40c486da31f315ca4c607a2c7d1c97c82a01301e2a6
| src/wallet/db.cpp | diff1 | diff2 | blobhistory |