| commit | 745bbdc189b29cd42eb93b9b00fb2cf7ab6f49b5 | |
| author | Wladimir J. van der Laan <laanwj@gmail.com> | |
| Mon, 28 Aug 2017 07:43:39 +0000 (28 09:43 +0200) | ||
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | |
| Mon, 28 Aug 2017 07:43:49 +0000 (28 09:43 +0200) | ||
| tree | 62642f3ba9222036255d5761801082a2fea6a375 | treesnapshot (tar.gz zip) |
| parent | 298251161c7b637157885420b35d7601e072923b | commitdiff |
| parent | b426e24678eb65d791cb505011e3ba4655aef1cd | commitdiff |
Merge #11161: Remove redundant explicitly defined copy ctors
b426e24 Remove redundant explicitly defined copy ctors (Dan Raviv)
Pull request description:
CFeeRate and CTxMemPoolEntry have explicitly defined copy ctors which has the same functionality as the implicit default copy ctors which would have been generated otherwise.
Besides being redundant, it violates the rule of three (see https://en.wikipedia.org/wiki/Rule_of_three_(C%2B%2B_programming) ).
(Of course, the rule of three doesn't -really- cause a resource management issue here, but the reason for that is exactly that there is no need for an explicit copy ctor in the first place since no resources are being managed).
Tree-SHA512: c9294ebf5d955d230b44c6f0d20822975d44a34471a717d656f8b17181bcd2827f47ba897edf5accd650f5998c58aadc8ab3c91a3f556f1f6de36830ed4069ce
b426e24 Remove redundant explicitly defined copy ctors (Dan Raviv)
Pull request description:
CFeeRate and CTxMemPoolEntry have explicitly defined copy ctors which has the same functionality as the implicit default copy ctors which would have been generated otherwise.
Besides being redundant, it violates the rule of three (see https://en.wikipedia.org/wiki/Rule_of_three_(C%2B%2B_programming) ).
(Of course, the rule of three doesn't -really- cause a resource management issue here, but the reason for that is exactly that there is no need for an explicit copy ctor in the first place since no resources are being managed).
Tree-SHA512: c9294ebf5d955d230b44c6f0d20822975d44a34471a717d656f8b17181bcd2827f47ba897edf5accd650f5998c58aadc8ab3c91a3f556f1f6de36830ed4069ce