| commit | 6a18bb9a3603839160dd77b671d5f59d12bd2666 | |
| author | John Newbery <john@johnnewbery.com> | |
| Wed, 29 Mar 2017 15:37:00 +0000 (29 11:37 -0400) | ||
| committer | John Newbery <john@johnnewbery.com> | |
| Thu, 30 Mar 2017 12:39:12 +0000 (30 08:39 -0400) | ||
| tree | 922efd5af9afe0ea440d5e1d949eea6253ba29dd | treesnapshot (tar.gz zip) |
| parent | 6426716a9940eea0e4d6e53c55282de5de473784 | commitdiff |
[tests] sync_with_ping should assert that ping hasn't timed out
sync_with_ping currently returns false if the timeout expires, and it is
the caller's responsibility to fail the test. However, none of the tests
currently assert on sync_with_ping()'s return code. This commit adds an
assert to sync_with_ping so the test will fail if the timeout expires.
This commit also removes all the duplicate implementations of
sync_with_ping() from the individual tests.
sync_with_ping currently returns false if the timeout expires, and it is
the caller's responsibility to fail the test. However, none of the tests
currently assert on sync_with_ping()'s return code. This commit adds an
assert to sync_with_ping so the test will fail if the timeout expires.
This commit also removes all the duplicate implementations of
sync_with_ping() from the individual tests.