| commit | 09627b1dd41d1151a709d5ead82a924bf59e3d38 | |
| author | Wladimir J. van der Laan <laanwj@gmail.com> | |
| Fri, 15 Sep 2017 07:55:14 +0000 (15 09:55 +0200) | ||
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | |
| Fri, 15 Sep 2017 07:55:23 +0000 (15 09:55 +0200) | ||
| tree | 7d797caf8a314f716a3935cb3f4f67e223ca63c2 | treesnapshot (tar.gz zip) |
| parent | ae233c4ec3d14a97c6195059f52873cdba2b4755 | commitdiff |
| parent | cdaf3a1f9e93be273ebf3e470dc709828c55476c | commitdiff |
Merge #11332: Fix possible crash with invalid nCustomFeeRadio in QSettings (achow101, TheBlueMatt)
cdaf3a1 Fix Qt 0.14.2->0.15.0 segfault if "total at least" is selected (Matt Corallo)
Pull request description:
`QButtonGroup->button()` may return a nullptr.
Accessing the object directly with `setChecked` seems fragile.
This is a simple fix to ensure to never call a button out of bounds (nullptr).
There are probably other places where a sanity check for `QSettings` are required.
Found by @achow101.
Code by @TheBlueMatt.
Tree-SHA512: a1b5d6636382a4e20c4e66ef82de19e6daa8b1b5f21b0f2bc5f51cfb6b37797045c7e29ebead8088ee2b990ed12c549c217cae6aad7566319599d086d526f6dc
cdaf3a1 Fix Qt 0.14.2->0.15.0 segfault if "total at least" is selected (Matt Corallo)
Pull request description:
`QButtonGroup->button()` may return a nullptr.
Accessing the object directly with `setChecked` seems fragile.
This is a simple fix to ensure to never call a button out of bounds (nullptr).
There are probably other places where a sanity check for `QSettings` are required.
Found by @achow101.
Code by @TheBlueMatt.
Tree-SHA512: a1b5d6636382a4e20c4e66ef82de19e6daa8b1b5f21b0f2bc5f51cfb6b37797045c7e29ebead8088ee2b990ed12c549c217cae6aad7566319599d086d526f6dc