From 469b584ec3bbbdfe5e253a37d14b336239e36990 Mon Sep 17 00:00:00 2001 From: Joern Rennecke Date: Fri, 7 Jun 2002 10:24:56 +0000 Subject: [PATCH] Add comment for last change. --- gas/config/tc-sh.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/gas/config/tc-sh.c b/gas/config/tc-sh.c index cd6f90c86..f7aa62515 100644 --- a/gas/config/tc-sh.c +++ b/gas/config/tc-sh.c @@ -1383,6 +1383,21 @@ parse_at (src, op) } else if (mode == A_PC) { + /* We want @(expr, pc) to uniformly address . + expr, + no matter if expr is a constant, or a more complex + expression, e.g. sym-. or sym1-sym2. + However, we also used to accept @(sym,pc) + as adressing sym, i.e. meaning the same as plain sym. + Some existing code does use the @(sym,pc) syntax, so + we give it the old semantics for now, but warn about + its use, so that users have some time to fix their code. + + Note that due to this backward compatibility hack, + we'll get unexpected results when @(offset, pc) is used, + and offset is a symbol that is set later to an an address + difference, or an external symbol that is set to an + address difference in another source file, so we want to + eventually remove it. */ if (op->immediate.X_op == O_symbol) { op->type = A_DISP_PC; -- 2.11.4.GIT