From dd88f42597e903a7847b9ffc10fee4fbbbd66cf8 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Mon, 26 Feb 2024 16:03:45 +0100 Subject: [PATCH] [gdb/testsuite] Dump dap.log.$n to gdb.log when exceptions found For a patch I submitted, the Linaro CI reported a failure: ... FAIL: gdb.dap/attach.exp: exceptions in log file ... I ran the test-case locally, and observed the same FAIL in the gdb.sum file. I then wanted to confirm that I reproduced the exact same problem, but realized that I couldn't because there's no way for me to know what exception occurred, and where, because that information is logged in the dap.log.$n file, and the Linaro CI only saves the gdb.sum and gdb.log files. This issue is even worse if only the CI can reproduce a FAIL. Fix this in dap_check_log_file by dumping dap.log.$n to gdb.log when exceptions are found. Tested on x86_64-linux. Approved-By: Tom Tromey --- gdb/testsuite/lib/dap-support.exp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdb/testsuite/lib/dap-support.exp b/gdb/testsuite/lib/dap-support.exp index 72c22d00711..89a4b0e0f6d 100644 --- a/gdb/testsuite/lib/dap-support.exp +++ b/gdb/testsuite/lib/dap-support.exp @@ -381,6 +381,9 @@ proc dap_check_log_file {} { if {$ok} { pass "exceptions in log file" } else { + verbose -log -- "--- DAP LOG START ---" + verbose -log -- $contents + verbose -log -- "--- DAP LOG END ---" fail "exceptions in log file" } } -- 2.11.4.GIT