| commit | 4d575e447f25623c219278f4773bca58289326e5 | |
| author | Chris Frey <cdfrey@foursquare.net> | |
| Sat, 12 Nov 2011 05:34:00 +0000 (12 00:34 -0500) | ||
| committer | Chris Frey <cdfrey@foursquare.net> | |
| Sat, 12 Nov 2011 05:48:47 +0000 (12 00:48 -0500) | ||
| tree | 0e20390c2083eebe8ae540003cb2faa2abc8af8b | treesnapshot (tar.gz zip) |
| parent | 33b428e9c400eea17b0a8acfd96c6f2d21a787d5 | commitdiff |
lib: added constructors to derived message record classes
The MessageBase class calls Clear() in the constructor, but this cannot
call the derived class's Clear(), since it does not exist yet.
Therefore all derived classes must call this themselves again.
Ideally, MessageBase's destructor should also be virtual here, but
there are no other virtual members, and the class inheritance here
is purely for implementation convenience. MessageBase objects are not
meant to be used alone (see protected constructor/destructors).
Leaving MessageBase non-virtual for now... feel free to convince me
otherwise if this affects you.
The MessageBase class calls Clear() in the constructor, but this cannot
call the derived class's Clear(), since it does not exist yet.
Therefore all derived classes must call this themselves again.
Ideally, MessageBase's destructor should also be virtual here, but
there are no other virtual members, and the class inheritance here
is purely for implementation convenience. MessageBase objects are not
meant to be used alone (see protected constructor/destructors).
Leaving MessageBase non-virtual for now... feel free to convince me
otherwise if this affects you.
| src/r_message.h | diffblobblamehistory | |
| src/r_pin_message.h | diffblobblamehistory | |
| src/r_saved_message.h | diffblobblamehistory |