From 6319fad3fa37e89b904f94d107f407146dda6165 Mon Sep 17 00:00:00 2001 From: Chris Frey Date: Thu, 19 Jun 2008 17:50:56 -0400 Subject: [PATCH] Added the m_filter for ipmodem PPP 0x7e filtering According to Rick Scott, the PPP 0x7e filter is not needed when in IpModem mode, but using the 8320 with Rogers, it doesn't seem to connect without it. If this is a performance problem, perhaps make this a runtime or command line option. --- ChangeLog | 2 ++ src/m_ipmodem.cc | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 4554d09c..cbb29934 100644 --- a/ChangeLog +++ b/ChangeLog @@ -12,6 +12,8 @@ Release: version 0.13 - 2008/06/?? - removed catch(...) - renamed class variable session_key to match others - added check to skip password if "" is passed in + - added the m_filter for ipmodem PPP 0x7e filtering + back, since the 8320 w/ rogers seems to need it 2008/06/06 - added timeout argument to Device::BulkDrain() - added mozilla's sha1 code from git diff --git a/src/m_ipmodem.cc b/src/m_ipmodem.cc index 4edd1afc..29b8f856 100644 --- a/src/m_ipmodem.cc +++ b/src/m_ipmodem.cc @@ -276,7 +276,11 @@ void IpModem::Write(const Data &data, int timeout) return; // nothing to do // according to Rick Scott the m_filter is not needed with the ip modem - m_dev.BulkWrite(m_con.GetProbeResult().m_epModem.write, data, timeout); + // but with the 8320 with Rogers, it doesn't seem to connect without it + // If this is a performance problem, perhaps make this a runtime + // option. + m_dev.BulkWrite(m_con.GetProbeResult().m_epModem.write, + m_filter.Write(data), timeout); } void IpModem::Close() -- 2.11.4.GIT