From ce6f18b3045710b2c5a7599fc9262f6c09239651 Mon Sep 17 00:00:00 2001
From: cdfrey <cdfrey>
Date: Fri, 30 Nov 2007 04:38:47 +0000
Subject: [PATCH] - added explanatory comments to udev rules files, about why 
 they are so verbose

---
 ChangeLog                       |  2 ++
 udev/10-blackberry.rules        | 13 +++++++++++++
 udev/10-blackberry.rules.Debian | 13 +++++++++++++
 3 files changed, 28 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index e9a705bd..c605c205 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -20,6 +20,8 @@ Release: version 0.10 - 2007/10/12
 			make applications look more capable, not less.
 	- updated btool to show errors logged by Probe
 	- added message to specify which PIN device is being used by btool
+	- added explanatory comments to udev rules files, about why
+		they are so verbose
 2007/11/27
 	- added ClearHalt() calls to probe and controller classes, just
 		before any communication happens... the 8830 seems
diff --git a/udev/10-blackberry.rules b/udev/10-blackberry.rules
index a1f2a575..ff374594 100644
--- a/udev/10-blackberry.rules
+++ b/udev/10-blackberry.rules
@@ -1,6 +1,19 @@
 #
 # Blackberry devices
 #
+# Note: the following rules may appear wasteful, in that bcharge is run
+#       twice: once for changing the mode, and once again after the
+#       device resets itself to enter this mode.  This is required
+#       in order to support older kernels (approx. 2.6.20 to 2.6.22) with
+#       CONFIG_USB_SUSPEND enabled.  The second time bcharge is run
+#       is when the -p argument comes into play, adjusting the device's
+#       autosuspend settings.
+#
+# Note2: the SUBSYSTEM and ENV{DEVTYPE} checks are to prevent bcharge from
+#       running each time a new endpoint is discovered by udev.
+#
+
+#
 # Older devices that only use 0x0001 (no USB Mass Storage)
 #
 
diff --git a/udev/10-blackberry.rules.Debian b/udev/10-blackberry.rules.Debian
index 6ebb6afb..6090b03b 100644
--- a/udev/10-blackberry.rules.Debian
+++ b/udev/10-blackberry.rules.Debian
@@ -1,6 +1,19 @@
 #
 # Blackberry devices
 #
+# Note: the following rules may appear wasteful, in that bcharge is run
+#       twice: once for changing the mode, and once again after the
+#       device resets itself to enter this mode.  This is required
+#       in order to support older kernels (approx. 2.6.20 to 2.6.22) with
+#       CONFIG_USB_SUSPEND enabled.  The second time bcharge is run
+#       is when the -p argument comes into play, adjusting the device's
+#       autosuspend settings.
+#
+# Note2: the SUBSYSTEM and ENV{DEVTYPE} checks are to prevent bcharge from
+#       running each time a new endpoint is discovered by udev.
+#
+
+#
 # Older devices that only use 0x0001 (no USB Mass Storage)
 #
 BUS=="usb", SUBSYSTEM=="usb_device", ACTION=="add", SYSFS{idVendor}=="0fca", SYSFS{idProduct}=="0001", SYMLINK+="bb-%k", GROUP="plugdev", MODE="0660", RUN="/usr/sbin/bcharge -p %p"
-- 
2.11.4.GIT