| commit | b2abfcf43d32a0f125d6f27687f362b6e345a4bf | |
| author | Nicholas Little <arealityfarbetween@googlemail.com> | |
| Tue, 3 Jun 2014 11:30:24 +0000 (3 13:30 +0200) | ||
| committer | Andrés G. Aragoneses <knocte@gmail.com> | |
| Tue, 3 Jun 2014 11:30:24 +0000 (3 13:30 +0200) | ||
| tree | 5b9e0bf65a5884eeea121d1982a646338bb9a442 | treesnapshot (tar.gz zip) |
| parent | 3efd419d7dcdf4597645b93b2d48e72a3f8ca88e | commitdiff |
Dap.MassStorage: add logging to empty catch{} blocks
While finding a fix for bug 729438 we have gone through some
scenarios in which an exception was being thrown, and caught
by empty catch{} blocks, hiding a regression which would have
been a bit clear if there was at least some logging in these
code flows.
So let's add it. If it becomes too noisy, we could still move
it to only be logged on debug mode, but never logging it looks
like a mistake.
Signed-off-by: Andrés G. Aragoneses <knocte@gmail.com>
While finding a fix for bug 729438 we have gone through some
scenarios in which an exception was being thrown, and caught
by empty catch{} blocks, hiding a regression which would have
been a bit clear if there was at least some logging in these
code flows.
So let's add it. If it becomes too noisy, we could still move
it to only be logged on debug mode, but never logging it looks
like a mistake.
Signed-off-by: Andrés G. Aragoneses <knocte@gmail.com>
| src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs | diffblobblamehistory |