| commit | ed66fda1f1d390db18383810c6f91e5aec6ebf16 | |
| author | Uli Schlachter <psychon@znc.in> | |
| Fri, 4 Oct 2013 12:31:48 +0000 (4 14:31 +0200) | ||
| committer | Uli Schlachter <psychon@znc.in> | |
| Fri, 4 Oct 2013 12:39:35 +0000 (4 14:39 +0200) | ||
| tree | 19bb1741fb93d44566c7d5670df3412ca10098ed | treesnapshot (tar.gz zip) |
| parent | e858163a0fc7226a7299af65083a6fea0824fa9a | commitdiff |
client: Ignore transient_for causing loops (FS#1124)
Lots of code assumes that it can recursively follow a client's transient_for
field until it reached an end without a transient_for client. Instead of fixing
all those places to properly handle loops, this patch just makes us ignore
WM_TRANSIENT_FOR if the property causes a loop.
This means that it can be a little random which WM_TRANSIENT_FOR property is
ignored, because it will always be the one that happens to complete the cycle. I
don't think that this is bad, because there shouldn't be any loops in the first
place.
Lots-of-kudos-to: David Mohr <david@mcbf.net>
Signed-off-by: Uli Schlachter <psychon@znc.in>
Lots of code assumes that it can recursively follow a client's transient_for
field until it reached an end without a transient_for client. Instead of fixing
all those places to properly handle loops, this patch just makes us ignore
WM_TRANSIENT_FOR if the property causes a loop.
This means that it can be a little random which WM_TRANSIENT_FOR property is
ignored, because it will always be the one that happens to complete the cycle. I
don't think that this is bad, because there shouldn't be any loops in the first
place.
Lots-of-kudos-to: David Mohr <david@mcbf.net>
Signed-off-by: Uli Schlachter <psychon@znc.in>
| property.c | diffblobblamehistory |