From 9b5ba8507fca0d6b94c167572c854d106f2da8cb Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sat, 2 Mar 1996 22:02:42 +0000 Subject: [PATCH] Bug fixes --- ChangeLog | 6 ++++++ TODO | 14 -------------- automake.in | 28 ++++++++++++++++++---------- 3 files changed, 24 insertions(+), 24 deletions(-) diff --git a/ChangeLog b/ChangeLog index 991e2ea3d..2893e7131 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +Sat Mar 2 14:04:38 1996 Tom Tromey + + * automake.in (handle_dist_worker): Only cause Automake to be + re-run if not making a distribution. Fixes bug reported by + Joerg-Martin Schwarz. + Fri Mar 1 00:13:04 1996 Tom Tromey * automake.in (parse_arguments): Default strictness is gnu. diff --git a/TODO b/TODO index 1bcfbd5ef..db8959e30 100644 --- a/TODO +++ b/TODO @@ -1,7 +1,6 @@ Priorities for release: * Check all require_file errors to see if any should reference a line in Makefile.am or configure.in. [handle_configure does] -* Error if program name not acceptable as makefile variable name * Add prog_CFLAGS Franc,ois> * Do you speak somewhere of the capability Automake has to let @@ -25,21 +24,12 @@ Other priorities: * Rewrite clean targets. * Expand test suite. ->>>>> "JMS" == Joerg-Martin Schwarz writes: -JMS> make dist requires that automake be installed, even if the -JMS> current Makefile.in already includes all dependency files. This -JMS> way one cannot re-create the tar file from the extracted source -JMS> file tree. - Consider allowing mkinstalldirs, mdate-sh, and others to be put in AC_CONFIG_AUX_DIR. Maybe even ansi2knr? Testing: allow support for Cygnus-style dejagnu-based test suites via an option -when in subdir that itself has subdirs, might need to do -include-by-reference TAGS file. - Think about ways to make automake fit better with Cygnus-style trees. Use recode in dist target when MAIN_CHARSET specified. Read caveats @@ -138,8 +128,6 @@ I agree, but I don't see how to implement this yet. It might be easier if "derived files" is limited to those that Automake itself knows about, eg output of yacc. -Should COPYING.LIB be distributed? - Check all source files to make sure that FSF address is up-to-date. --gnits or --gnu only. @@ -170,8 +158,6 @@ Should handle directory hierarchies deeper than 2. Right now there is some support for this. Here are some of the issues: * Should handle AC_CONFIG_SUBDIRS, ie must handle configure.in in subdirs * Must handle SUBDIRS in subdir Makefile.am's -* Must handle AC_CONFIG_AUX_DIR - * FIXME must already look in .. and ../.. ================================================================ diff --git a/automake.in b/automake.in index 85a6ac85c..abb4b6693 100755 --- a/automake.in +++ b/automake.in @@ -973,20 +973,28 @@ sub handle_dist_worker $output_rules .= - ( - # Create dist directory. - ' rm -rf $(distdir) + # Create dist directory. + ' rm -rf $(distdir) mkdir $(distdir) chmod 777 $(distdir) -' - # We need an absolute path for --output-dir. Thus the - # weirdness. - . ' distdir=`cd $(distdir) && pwd` \\ +'; + + # Only run automake in `dist' target if --include-deps not + # specified. That way the recipient of a distribution can run + # "make dist" and not need Automake. + if ($cmdline_use_dependencies) + { + $output_rules .= + ( + # We need an absolute path for --output-dir. Thus the + # weirdness. + ' distdir=`cd $(distdir) && pwd` \\ && cd $(srcdir) \\ && automake --include-deps --output-dir=$$distdir --strictness=' - # Set strictness of output. - . $strictness_name . "\n" - ); + # Set strictness of output. + . $strictness_name . "\n" + ); + } } # In loop, test for file existence because sometimes a file gets -- 2.11.4.GIT