| commit | a9796703447fc5c5691b749915f0f627f47f05a9 | |
| author | Glauber Costa <glommer@redhat.com> | |
| Thu, 17 Sep 2009 20:53:39 +0000 (17 16:53 -0400) | ||
| committer | Anthony Liguori <aliguori@us.ibm.com> | |
| Mon, 5 Oct 2009 14:32:44 +0000 (5 09:32 -0500) | ||
| tree | 5a081b62ed2015fa99669feffa01ea4dc8bed3b6 | treesnapshot (tar.gz zip) |
| parent | e5bc201df7e060bc4c2912258a77c53f8901356c | commitdiff |
Correctly free nd structure
When we "free" a NICInfo structure, we can leak pointers, since we don't do
much more than setting used = 0.
We free() the model parameter, but we don't set it to NULL. This means that
a new user of this structure will see garbage in there. It was not noticed
before because reusing a NICInfo is not that common, but it can be, for
users of device pci hotplug.
A user hit it, described at https://bugzilla.redhat.com/show_bug.cgi?id=524022
This patch memset's the whole structure, guaranteeing that anyone reusing it
will see a fresh NICinfo. Also, we free some other strings that are currently
leaking.
This codebase is quite old, so this patch should feed all stable trees.
Signed-off-by: Glauber Costa <glommer@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
When we "free" a NICInfo structure, we can leak pointers, since we don't do
much more than setting used = 0.
We free() the model parameter, but we don't set it to NULL. This means that
a new user of this structure will see garbage in there. It was not noticed
before because reusing a NICInfo is not that common, but it can be, for
users of device pci hotplug.
A user hit it, described at https://bugzilla.redhat.com/show_bug.cgi?id=524022
This patch memset's the whole structure, guaranteeing that anyone reusing it
will see a fresh NICinfo. Also, we free some other strings that are currently
leaking.
This codebase is quite old, so this patch should feed all stable trees.
Signed-off-by: Glauber Costa <glommer@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| net.c | diffblobblamehistory |