From b9901b9bb25a6bc8d2107d09766dae6a6f0d1f7d Mon Sep 17 00:00:00 2001 From: Alan Haggai Alavi Date: Sat, 23 Jan 2010 02:22:25 +0000 Subject: [PATCH] Updated perl minimum version to 5.004. Replaced three-argument open with two-argument open for backward compatibility. --- Makefile.PL | 6 +++--- lib/Archive/Zip.pm | 2 +- t/09_output_record_sep.t | 2 +- t/10_chmod.t | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index 34ca30c..5ea3069 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -1,13 +1,13 @@ use strict; BEGIN { - require 5.003_96; + require 5.004; } use Config; use ExtUtils::MakeMaker; WriteMakefile1( - MIN_PERL_VERSION => '5.00396', + MIN_PERL_VERSION => '5.004', META_MERGE => { resources => { repository => 'http://svn.ali.as/cpan/trunk/Archive-Zip', @@ -54,7 +54,7 @@ WriteMakefile1( ZIPFLAGS => '-r' }, LICENSE => 'perl', - 'MIN_PERL_VERSION' => 5.003_96, + 'MIN_PERL_VERSION' => 5.004, ( $] >= 5.005 ? ( BINARY_LOCATION => $Config{'archname'} . "/\$(DISTVNAME)-PPD.tar\$(SUFFIX)", AUTHOR => 'Ned Konz ', diff --git a/lib/Archive/Zip.pm b/lib/Archive/Zip.pm index e4ae8d2..5cb5126 100644 --- a/lib/Archive/Zip.pm +++ b/lib/Archive/Zip.pm @@ -2,7 +2,7 @@ package Archive::Zip; use strict; BEGIN { - require 5.003_96; + require 5.004; } use UNIVERSAL (); use Carp (); diff --git a/t/09_output_record_sep.t b/t/09_output_record_sep.t index f5aac5d..ccb597c 100644 --- a/t/09_output_record_sep.t +++ b/t/09_output_record_sep.t @@ -23,7 +23,7 @@ my $archive_fn = "out.zip"; my ( $before, $after ); sub slurp_file { my $filename = shift; - open ( my $fh, '<', $filename) + open my $fh, "<$filename" or die 'Can not open file'; my $contents; binmode( $fh ); diff --git a/t/10_chmod.t b/t/10_chmod.t index 7ae647f..688de9b 100644 --- a/t/10_chmod.t +++ b/t/10_chmod.t @@ -27,7 +27,7 @@ sub test_if_chmod_is_working mkdir($test_dir, 0755); - open my $out, ">", $test_file; + open my $out, ">$test_file"; print {$out} "Foobar."; close($out); -- 2.11.4.GIT