From f0df5e7bb03072d06f516c3ff40b32e65ccb2a7c Mon Sep 17 00:00:00 2001
From: Felix Bechstein <f@ub0r.de>
Date: Fri, 29 Jan 2010 14:46:20 +0100
Subject: [PATCH] fix unnecessary updates on balance

---
 src/de/ub0r/android/websms/WebSMS.java | 8 ++++----
 todo.list                              | 1 -
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/de/ub0r/android/websms/WebSMS.java b/src/de/ub0r/android/websms/WebSMS.java
index a73abc0..7a7a6e3 100644
--- a/src/de/ub0r/android/websms/WebSMS.java
+++ b/src/de/ub0r/android/websms/WebSMS.java
@@ -426,7 +426,6 @@ public class WebSMS extends Activity implements OnClickListener,
 	 */
 	private void updateBalance() {
 		final StringBuilder buf = new StringBuilder();
-		// FIXME: this method is run way to often!
 		final ConnectorSpec[] css = getConnectors(
 				ConnectorSpec.CAPABILITIES_UPDATE, // .
 				ConnectorSpec.STATUS_ENABLED);
@@ -1076,7 +1075,7 @@ public class WebSMS extends Activity implements OnClickListener,
 					|| connector.getName() == null) {
 				return;
 			}
-			final ConnectorSpec c = getConnectorByID(connector.getID());
+			ConnectorSpec c = getConnectorByID(connector.getID());
 			if (c != null) {
 				c.update(connector);
 			} else {
@@ -1100,6 +1099,7 @@ public class WebSMS extends Activity implements OnClickListener,
 				if (!added) {
 					CONNECTORS.add(connector);
 				}
+				c = connector;
 
 				if (prefsConnectorSpec == null
 						&& prefsConnectorID.equals(connector.getID())) {
@@ -1111,8 +1111,8 @@ public class WebSMS extends Activity implements OnClickListener,
 					me.setButtons();
 				}
 			}
-			final String b = connector.getBalance();
-			final String ob = connector.getOldBalance();
+			final String b = c.getBalance();
+			final String ob = c.getOldBalance();
 			if (b != null && (ob == null || !b.equals(ob))) {
 				me.updateBalance();
 			}
diff --git a/todo.list b/todo.list
index 3a7ca70..7d0e0c4 100644
--- a/todo.list
+++ b/todo.list
@@ -1,6 +1,5 @@
 check for new connectors
 implement limitLength in websms
-fix massive broadcasts
 add notification for IO to websms statusbar
 fix $(grep -Fr FIXME)
 fix $(grep -Fr TODO)
-- 
2.11.4.GIT