| commit | 528c94f29c2f7a6eb2ee88e0432ab362542da538 | |
| author | upstream svn <svn@amule.org> | |
| Fri, 22 Jul 2016 19:24:59 +0000 (22 19:24 +0000) | ||
| committer | Dévai Tamás <gonosztopi@amule.org> | |
| Fri, 22 Jul 2016 22:17:35 +0000 (22 22:17 +0000) | ||
| tree | 9c78a487e45ef7109ca71ee8de067a2839f856fe | treesnapshot (tar.gz zip) |
| parent | 7bdc354b1fed07aff718e975a4ac66cd0f0ce939 | commitdiff |
Remove possible double encoding from shareddir.dat
Since CTextFile already ensures shareddir.dat is written/read in UTF-8, that's
universal enough. Using CPath::{To,From}Univ() functions would require characters
outside the current system code page (or ISO-8859-1) being double-encoded in
UTF-8, rendering shareddir.dat not editable by the user.
Though it works in UTF-8 locales, fails miserably otherwise.
Regarding CPath::{To,From}Univ, it is under investigation whether these functions
are needed at all. Until then, changed back wxConvLocal to wxConvISO8859_1, the
former is definitely not a good choice.
Since CTextFile already ensures shareddir.dat is written/read in UTF-8, that's
universal enough. Using CPath::{To,From}Univ() functions would require characters
outside the current system code page (or ISO-8859-1) being double-encoded in
UTF-8, rendering shareddir.dat not editable by the user.
Though it works in UTF-8 locales, fails miserably otherwise.
Regarding CPath::{To,From}Univ, it is under investigation whether these functions
are needed at all. Until then, changed back wxConvLocal to wxConvISO8859_1, the
former is definitely not a good choice.
| .svn-revision | diffblobblamehistory | |
| src/Preferences.cpp | diffblobblamehistory | |
| src/libs/common/Path.cpp | diffblobblamehistory |