| commit | b3ca9c7f3a510da3abf8476c5c7a684317792916 | |
| author | (no author) <(no author)@41a61cd8-c433-0410-bb1c-e256eeef9e11> | |
| Sat, 13 Oct 2007 01:14:24 +0000 (13 01:14 +0000) | ||
| committer | (no author) <(no author)@41a61cd8-c433-0410-bb1c-e256eeef9e11> | |
| Sat, 13 Oct 2007 01:14:24 +0000 (13 01:14 +0000) | ||
| tree | bff0f569f3a1bd1d3ab10ee082a9b53f4e4a360c | treesnapshot (tar.gz zip) |
| parent | 1040365af42c084cc365c86a47f1e909134600f7 | commitdiff |
r1284@dev030 (orig r63557): cpiro | 2007-10-12 18:11:46 -0700
[thrift] retool oop.erl, fix tBufferedTransportFactory.erl
Summary: oop.erl used to assume that an undef or function_clause meant a method wasn't defined, but sometimes a method does exist and an undef happens while it's executing.
Case in point, getTransport in tBufferedTransportFactory totally didn't work and instead of exiting, oop.erl fell back silently to tTransportFactory, so everywhere I thought I was talking to tBufferedTransport, I was talking directly to the tSocket. borkborkbork.
Blame: all me baby
Reviewed By: eletuchy
Test Plan: channel server works
Revert Plan: ok
git-svn-id: http://svn.facebook.com/svnroot/thrift/trunk@627 41a61cd8-c433-0410-bb1c-e256eeef9e11
[thrift] retool oop.erl, fix tBufferedTransportFactory.erl
Summary: oop.erl used to assume that an undef or function_clause meant a method wasn't defined, but sometimes a method does exist and an undef happens while it's executing.
Case in point, getTransport in tBufferedTransportFactory totally didn't work and instead of exiting, oop.erl fell back silently to tTransportFactory, so everywhere I thought I was talking to tBufferedTransport, I was talking directly to the tSocket. borkborkbork.
Blame: all me baby
Reviewed By: eletuchy
Test Plan: channel server works
Revert Plan: ok
git-svn-id: http://svn.facebook.com/svnroot/thrift/trunk@627 41a61cd8-c433-0410-bb1c-e256eeef9e11