| commit | ad5ddb5563f8175d42a510a8e92d1a92880a1261 | |
| author | (no author) <(no author)@41a61cd8-c433-0410-bb1c-e256eeef9e11> | |
| Tue, 13 Nov 2007 04:02:11 +0000 (13 04:02 +0000) | ||
| committer | (no author) <(no author)@41a61cd8-c433-0410-bb1c-e256eeef9e11> | |
| Tue, 13 Nov 2007 04:02:11 +0000 (13 04:02 +0000) | ||
| tree | 16e0768d3a13702182643c7e00d1c4909132de81 | treesnapshot (tar.gz zip) |
| parent | 5352a6102ddb1d2abcdc92a96546b22fddf6a137 | commitdiff |
r1275@opsdev009 (orig r69342): mcslee | 2007-11-12 20:00:29 -0800
Thrift PHP generation Redux
Summary: Chopping the amount of code generated by Thrift for PHP services by two orders of magnitude (approx 25% of the previous size). This is done via putting more logic in a dynamic base class and taking it out of the generated code. Hopefully this wins back the CPU cycles paid just to load code from APC at the cost of a marginal increase in dynamic execution runtime.
Reviewed By: sgrimm, dreiss
Test Plan: Ran all the tests in trunk/test/php, also tested the API generate code and Falcon, etc. in my sandbox
git-svn-id: http://svn.facebook.com/svnroot/thrift/trunk@656 41a61cd8-c433-0410-bb1c-e256eeef9e11
Thrift PHP generation Redux
Summary: Chopping the amount of code generated by Thrift for PHP services by two orders of magnitude (approx 25% of the previous size). This is done via putting more logic in a dynamic base class and taking it out of the generated code. Hopefully this wins back the CPU cycles paid just to load code from APC at the cost of a marginal increase in dynamic execution runtime.
Reviewed By: sgrimm, dreiss
Test Plan: Ran all the tests in trunk/test/php, also tested the API generate code and Falcon, etc. in my sandbox
git-svn-id: http://svn.facebook.com/svnroot/thrift/trunk@656 41a61cd8-c433-0410-bb1c-e256eeef9e11