From ee756a8161734e28490616f05ba895182424490b Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Tue, 25 Nov 2014 14:52:42 -0800 Subject: [PATCH] t9001: style modernisation phase #4 Two general shell script codingstyles. - No SP between redirection operator and its target - One SP on both sides of () in "name () {" that begins a shell function Signed-off-by: Junio C Hamano --- t/t9001-send-email.sh | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index ce05a871e0..8aa7c0335f 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -31,7 +31,7 @@ test_expect_success $PREREQ 'Setup helper tool' ' GIT_AUTHOR_NAME="A" git commit -a -m "Second." ' -clean_fake_sendmail() { +clean_fake_sendmail () { rm -f commandline* msgtxt* } @@ -49,9 +49,9 @@ test_no_confirm () { --to=nobody@example.com \ --smtp-server="$(pwd)/fake.sendmail" \ $@ \ - $patches > stdout && + $patches >stdout && test_must_fail grep "Send this email" stdout && - > no_confirm_okay + >no_confirm_okay } # Exit immediately to prevent hang if a no-confirm test fails @@ -365,7 +365,7 @@ test_expect_success $PREREQ 'Author From: in message body' ' --to=nobody@example.com \ --smtp-server="$(pwd)/fake.sendmail" \ $patches && - sed "1,/^\$/d" < msgtxt1 > msgbody1 && + sed "1,/^\$/d" msgbody1 && grep "From: A " msgbody1 ' @@ -376,7 +376,7 @@ test_expect_success $PREREQ 'Author From: not in message body' ' --to=nobody@example.com \ --smtp-server="$(pwd)/fake.sendmail" \ $patches && - sed "1,/^\$/d" < msgtxt1 > msgbody1 && + sed "1,/^\$/d" msgbody1 && ! grep "From: A " msgbody1 ' @@ -790,7 +790,7 @@ test_confirm () { --from="Example " \ --to=nobody@example.com \ --smtp-server="$(pwd)/fake.sendmail" \ - $@ $patches > stdout && + $@ $patches >stdout && grep "Send this email" stdout } @@ -838,7 +838,7 @@ test_expect_success $PREREQ 'confirm detects EOF (inform assumes y)' ' --from="Example " \ --to=nobody@example.com \ --smtp-server="$(pwd)/fake.sendmail" \ - outdir/*.patch < /dev/null + outdir/*.patch master && + echo master >master && git add master && git commit -m"add master" && test_must_fail git send-email --dry-run master 2>errors && @@ -1403,7 +1403,7 @@ test_expect_success $PREREQ 'convert from quoted-printable to base64' ' ' test_expect_success $PREREQ 'setup expect' " -tr -d '\\015' | tr '%' '\\015' > email-using-crlf <email-using-crlf < From: A U Thor -- 2.11.4.GIT