From e861b0963626dd2732f7efbf2a187a85b060d9cb Mon Sep 17 00:00:00 2001 From: Jeff King Date: Wed, 6 Oct 2021 22:24:40 -0400 Subject: [PATCH] test-read-midx: fix leak of bitmap_index struct In read_midx_preferred_pack(), we open the bitmap index but never free it. This isn't a big deal since this is just a test helper, and we exit immediately after, but since we're trying to keep our leak-checking tidy now, it's worth fixing. Signed-off-by: Jeff King Acked-by: Taylor Blau Signed-off-by: Junio C Hamano --- t/helper/test-read-midx.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/t/helper/test-read-midx.c b/t/helper/test-read-midx.c index 0038559129..9d6fa7a377 100644 --- a/t/helper/test-read-midx.c +++ b/t/helper/test-read-midx.c @@ -85,11 +85,15 @@ static int read_midx_preferred_pack(const char *object_dir) return 1; bitmap = prepare_bitmap_git(the_repository); - if (!(bitmap && bitmap_is_midx(bitmap))) + if (!bitmap) return 1; - + if (!bitmap_is_midx(bitmap)) { + free_bitmap_index(bitmap); + return 1; + } printf("%s\n", midx->pack_names[midx_preferred_pack(bitmap)]); + free_bitmap_index(bitmap); return 0; } -- 2.11.4.GIT