From 73bbc0796b4ce65bfb1a12b47a0edc27845ecf50 Mon Sep 17 00:00:00 2001 From: Brandon Casey Date: Mon, 23 Sep 2013 11:49:08 -0700 Subject: [PATCH] contrib/git-credential-gnome-keyring.c: ensure buffer is non-empty before accessing Ensure buffer length is non-zero before attempting to access the last element. Signed-off-by: Brandon Casey Signed-off-by: Junio C Hamano --- contrib/credential/gnome-keyring/git-credential-gnome-keyring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c index b9bb794601..0d2c55e0d2 100644 --- a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c +++ b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c @@ -314,7 +314,7 @@ static int credential_read(struct credential *c) { line_len = strlen(buf); - if (buf[line_len-1]=='\n') + if (line_len && buf[line_len-1] == '\n') buf[--line_len]='\0'; if (!line_len) -- 2.11.4.GIT