From 0e7c41c0cd14b0d748ce624e49800b63f9b27991 Mon Sep 17 00:00:00 2001 From: Matthieu Moy Date: Wed, 3 Jul 2013 11:14:19 +0200 Subject: [PATCH] git-remote-mediawiki: un-brace file handles in binmode calls Commit e83d36b66fc turned "print STDOUT" into "print {*STDOUT}", as suggested by perlcritic. Unfortunately, it also changed two "binmode STDOUT" calls the same way, which does not work and yield a "Not a GLOB reference" error. Signed-off-by: Matthieu Moy Signed-off-by: Junio C Hamano --- contrib/mw-to-git/git-remote-mediawiki.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl index 71baf8ace8..d09f5da668 100755 --- a/contrib/mw-to-git/git-remote-mediawiki.perl +++ b/contrib/mw-to-git/git-remote-mediawiki.perl @@ -635,9 +635,9 @@ sub literal_data_raw { my ($content) = @_; # Avoid confusion between size in bytes and in characters utf8::downgrade($content); - binmode {*STDOUT}, ':raw'; + binmode STDOUT, ':raw'; print {*STDOUT} 'data ', bytes::length($content), "\n", $content; - binmode {*STDOUT}, ':encoding(UTF-8)'; + binmode STDOUT, ':encoding(UTF-8)'; return; } -- 2.11.4.GIT