| commit | fbbcafd0607d6fccb2fde39c49619bcd7a7b910b | |
| author | Junio C Hamano <gitster@pobox.com> | |
| Sun, 18 Oct 2015 22:40:06 +0000 (18 15:40 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 21 Oct 2015 22:37:50 +0000 (21 15:37 -0700) | ||
| tree | 38d0f902dee8950529f1ee26e5a6cb965660c559 | treesnapshot (tar.gz zip) |
| parent | 69e24defd629eb6641e653b73459f57ab750c58b | commitdiff |
mailinfo: do not let find_boundary() touch global "line" directly
With the previous two commits, we established that the local
variable "line" in handle_body() and handle_boundary() functions
always refer to the global "line" that is used as the common and
shared "current line from the input". They are the only callers of
the last function that refers to the global line directly, i.e.
find_boundary(). Pass "line" as a parameter to this leaf function
to complete the clean-up. Now the only function that directly refers
to the global "line" is the caller of handle_body() at the very
beginning of this whole callchain.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
With the previous two commits, we established that the local
variable "line" in handle_body() and handle_boundary() functions
always refer to the global "line" that is used as the common and
shared "current line from the input". They are the only callers of
the last function that refers to the global line directly, i.e.
find_boundary(). Pass "line" as a parameter to this leaf function
to complete the clean-up. Now the only function that directly refers
to the global "line" is the caller of handle_body() at the very
beginning of this whole callchain.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/mailinfo.c | diffblobblamehistory |