| commit | da09e7af68247519e2b19fc8dff113896c39ac3c | |
| author | Jeff King <peff@peff.net> | |
| Tue, 3 Oct 2023 20:31:30 +0000 (3 16:31 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 3 Oct 2023 21:28:24 +0000 (3 14:28 -0700) | ||
| tree | 311325c53668191327192c7cc4cc53e0cdbc97a7 | treesnapshot (tar.gz zip) |
| parent | d9c84c6d67e3418bade00af7bcb5f72d7c656164 | commitdiff |
commit-graph: clear oidset after finishing write
In graph_write() we store commits in an oidset, but never clean it up,
leaking the contents. We should clear it in the cleanup section.
The oidset comes from 6830c36077 (commit-graph.h: replace 'commit_hex'
with 'commits', 2020-04-13), but it was just replacing a string_list
that was also leaked. Curiously, we fixed the leak of some adjacent
variables in commit fa8953cb40 (builtin/commit-graph.c: extract
'read_one_commit()', 2020-05-18), but the oidset wasn't included for
some reason.
In combination with the preceding commits, this lets us mark t5324 as
leak-free.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
In graph_write() we store commits in an oidset, but never clean it up,
leaking the contents. We should clear it in the cleanup section.
The oidset comes from 6830c36077 (commit-graph.h: replace 'commit_hex'
with 'commits', 2020-04-13), but it was just replacing a string_list
that was also leaked. Curiously, we fixed the leak of some adjacent
variables in commit fa8953cb40 (builtin/commit-graph.c: extract
'read_one_commit()', 2020-05-18), but the oidset wasn't included for
some reason.
In combination with the preceding commits, this lets us mark t5324 as
leak-free.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/commit-graph.c | diffblobblamehistory | |
| t/t5324-split-commit-graph.sh | diffblobblamehistory |