| commit | c5e3bc6ec46071397b40582157214d374d1b4fab | |
| author | Phillip Wood <phillip.wood@dunelm.org.uk> | |
| Wed, 15 Nov 2017 12:40:43 +0000 (15 12:40 +0000) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 16 Nov 2017 01:36:16 +0000 (16 10:36 +0900) | ||
| tree | a698b2329a07becd0211adb62f8cb76066c9947c | treesnapshot (tar.gz zip) |
| parent | e5435ff1fc64d93cce73ec4ee2571219384a92a9 | commitdiff |
config: avoid "write_in_full(fd, buf, len) != len" pattern
As explained in commit 06f46f237 (avoid "write_in_full(fd, buf, len)
!= len" pattern, 2017–09–13) the return value of write_in_full() is
either -1 or the requested number of bytes. As such comparing the
return value to an unsigned value such as strbuf.len will fail to
catch errors. Change the code to use the preferred '< 0' check.
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
As explained in commit 06f46f237 (avoid "write_in_full(fd, buf, len)
!= len" pattern, 2017–09–13) the return value of write_in_full() is
either -1 or the requested number of bytes. As such comparing the
return value to an unsigned value such as strbuf.len will fail to
catch errors. Change the code to use the preferred '< 0' check.
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| config.c | diffblobblamehistory |