test: do not negate test_path_is_* to assert absense
commitb126b65b3381cd8659552b39699b3b3d9a4f5393
authorJunio C Hamano <gitster@pobox.com>
Tue, 16 May 2023 02:26:46 +0000 (15 19:26 -0700)
committerJunio C Hamano <gitster@pobox.com>
Tue, 16 May 2023 16:14:23 +0000 (16 09:14 -0700)
tree2f36757bff91eb3262b5e017dcdf12588cfa810c
parenteab648d2b4c1ca6fbc28de454b51d7d00f5a3e60
test: do not negate test_path_is_* to assert absense

These tests use "! test_path_is_dir" or "! test_path_is_file" to
ensure that the path is not recursively checked out or "submodule
update" did not touch the working tree.

Use "test_path_is_missing" to assert that the path does not exist,
instead of negating test_path_is_* helpers; they are designed to be
loud in wrong occasions.  Besides, negating "test_path_is_dir" would
mean we would be happy if a file exists there, which is not the case
for these tests.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/lib-submodule-update.sh
t/t5572-pull-submodule.sh