| commit | ae25974de301ba1809f2d7f0219fcdd86d18cc1f | |
| author | René Scharfe <l.s.r@web.de> | |
| Fri, 15 Jul 2022 03:58:50 +0000 (15 05:58 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 15 Jul 2022 05:45:05 +0000 (14 22:45 -0700) | ||
| tree | 23a5b1e3d43ff3d095eda9122fed3538ced16789 | treesnapshot (tar.gz zip) |
| parent | 359da658ae32d9a7e5e93ac173fc221352b62917 | commitdiff |
mingw: avoid mktemp() in mkstemp() implementation
The implementation of mkstemp() for MinGW uses mktemp() and open()
without the flag O_EXCL, which is racy. It's not a security problem
for now because all of its callers only create files within the
repository (incl. worktrees). Replace it with a call to our more
secure internal function, git_mkstemp_mode(), to prevent possible
future issues.
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The implementation of mkstemp() for MinGW uses mktemp() and open()
without the flag O_EXCL, which is racy. It's not a security problem
for now because all of its callers only create files within the
repository (incl. worktrees). Replace it with a call to our more
secure internal function, git_mkstemp_mode(), to prevent possible
future issues.
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| compat/mingw.c | diffblobblamehistory |