| commit | 9101c8ea2db466cce6d7d419d48e0516c6118813 | |
| author | Jeff King <peff@peff.net> | |
| Fri, 14 Aug 2020 16:14:14 +0000 (14 12:14 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 14 Aug 2020 17:52:04 +0000 (14 10:52 -0700) | ||
| tree | 60de998ff32bec753314aa306d065369a66bb7c7 | treesnapshot (tar.gz zip) |
| parent | 8dc3156373f4e02c1b1f657350ffae8ee94cbf44 | commitdiff |
submodule--helper: use strbuf_release() to free strbufs
The prepare_to_clone_next_submodule() function has a few local-variable
strbufs. We use strbuf_reset() throughout the function to reuse the
buffers over and over. But at the end of the function we also use
strbuf_reset() as they go out of scope, which means we end up leaking
their heap buffers. This should be strbuf_release() instead.
These were introduced by 48308681b0 (git submodule update: have a
dedicated helper for cloning, 2016-02-29), but it doesn't seem to have
the same mistake elsewhere. Likewise, I looked for other instances of
the pattern in the submodule--helper file but couldn't find any.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The prepare_to_clone_next_submodule() function has a few local-variable
strbufs. We use strbuf_reset() throughout the function to reuse the
buffers over and over. But at the end of the function we also use
strbuf_reset() as they go out of scope, which means we end up leaking
their heap buffers. This should be strbuf_release() instead.
These were introduced by 48308681b0 (git submodule update: have a
dedicated helper for cloning, 2016-02-29), but it doesn't seem to have
the same mistake elsewhere. Likewise, I looked for other instances of
the pattern in the submodule--helper file but couldn't find any.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/submodule--helper.c | diffblobblamehistory |