| commit | 85d9d9ddf38aba0c13a1be8f667af6b8cf021ca6 | |
| author | Nguyễn Thái Ngọc Duy <pclouds@gmail.com> | |
| Sun, 1 Nov 2015 14:30:30 +0000 (1 15:30 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sun, 1 Nov 2015 18:29:40 +0000 (1 10:29 -0800) | ||
| tree | 3a282a2a07d3a49039868e99da8613868fbf7290 | treesnapshot (tar.gz zip) |
| parent | 6ac617a321383b2e3a0f0537e3224ec6229e6500 | commitdiff |
mailinfo: fix passing wrong address to git_mailinfo_config
git_mailinfo_config() expects "struct mailinfo *". But in
setup_mailinfo(), "mi" is already "struct mailinfo *". &mi would make
it "struct mailinfo **" and git_mailinfo_config() would damage some
other memory when it assigns some value to mi->use_scissors.
This is caught by t4150.20. git_mailinfo_config() breaks
mi->name.alloc and makes strbuf_release() in clear_mailinfo() attempt
to free strbuf_slopbuf.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git_mailinfo_config() expects "struct mailinfo *". But in
setup_mailinfo(), "mi" is already "struct mailinfo *". &mi would make
it "struct mailinfo **" and git_mailinfo_config() would damage some
other memory when it assigns some value to mi->use_scissors.
This is caught by t4150.20. git_mailinfo_config() breaks
mi->name.alloc and makes strbuf_release() in clear_mailinfo() attempt
to free strbuf_slopbuf.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| mailinfo.c | diffblobblamehistory |