| commit | 838ba014ce8226e0fb6c87b1b1c587fc61582323 | |
| author | Jeff King <peff@peff.net> | |
| Wed, 20 Mar 2024 00:35:57 +0000 (19 20:35 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 20 Mar 2024 00:54:16 +0000 (19 17:54 -0700) | ||
| tree | eb43870c23c17b55cff40e1f6e808dd242b465a5 | treesnapshot (tar.gz zip) |
| parent | 305a68143cc0e9b714d71417efa9f0162dd07221 | commitdiff |
format-patch: simplify after-subject MIME header handling
In log_write_email_headers(), we append our MIME headers to the set of
extra headers by creating a new strbuf, adding the existing headers, and
then adding our new ones. We had to do it this way when our output
buffer might point to the constant opt->extra_headers variable.
But since the previous commit, we always make a local copy of that
variable. Let's turn that into a strbuf, which lets the MIME code simply
append to it. That simplifies the function and avoids a pointless extra
copy of the headers.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
In log_write_email_headers(), we append our MIME headers to the set of
extra headers by creating a new strbuf, adding the existing headers, and
then adding our new ones. We had to do it this way when our output
buffer might point to the constant opt->extra_headers variable.
But since the previous commit, we always make a local copy of that
variable. Let's turn that into a strbuf, which lets the MIME code simply
append to it. That simplifies the function and avoids a pointless extra
copy of the headers.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| log-tree.c | diffblobblamehistory |