| commit | 7b9cda2d3d7de794974ce6f29a2a838565cd338d | |
| author | Patrick Steinhardt <ps@pks.im> | |
| Mon, 15 Jan 2024 10:36:06 +0000 (15 11:36 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 16 Jan 2024 17:18:21 +0000 (16 09:18 -0800) | ||
| tree | 8d9a843938899b9551683af4ad2bb7d1fa1e2e10 | treesnapshot (tar.gz zip) |
| parent | 6807d3942c6104b32f6c7e04c1f7b5d2c82afa30 | commitdiff |
completion: improve existence check for pseudo-refs
Improve the existence check along the following lines:
- Stop stripping the "ref :" prefix and compare to the expected value
directly. This allows us to drop a now-unused variable that was
previously leaking into the user's shell.
- Mark the "head" variable as local so that we don't leak its value
into the user's shell.
- Stop manually handling the `-C $__git_repo_path` option, which the
`__git ()` wrapper aleady does for us.
- In simlar spirit, stop redirecting stderr, which is also handled by
the wrapper already.
Suggested-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Improve the existence check along the following lines:
- Stop stripping the "ref :" prefix and compare to the expected value
directly. This allows us to drop a now-unused variable that was
previously leaking into the user's shell.
- Mark the "head" variable as local so that we don't leak its value
into the user's shell.
- Stop manually handling the `-C $__git_repo_path` option, which the
`__git ()` wrapper aleady does for us.
- In simlar spirit, stop redirecting stderr, which is also handled by
the wrapper already.
Suggested-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| contrib/completion/git-completion.bash | diffblobblamehistory |