| commit | 739d8a16b5f1fefc42177c4619605c8cddb3a094 | |
| author | Christian Couder <christian.couder@gmail.com> | |
| Sun, 4 Sep 2016 20:18:18 +0000 (4 22:18 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 7 Sep 2016 19:29:53 +0000 (7 12:29 -0700) | ||
| tree | 2ffafc9fba7040559313088d2a5299e6ad520ef5 | treesnapshot (tar.gz zip) |
| parent | ccceb7bb13a37b1834bc1c455e40abc710997dd3 | commitdiff |
builtin/apply: make try_create_file() return -1 on error
To libify `git apply` functionality we have to signal errors to the
caller instead of die()ing.
To do that in a compatible manner with the rest of the error handling
in "builtin/apply.c", try_create_file() should return -1 in case of
error.
Unfortunately try_create_file() currently returns -1 to signal a
recoverable error. To fix that, let's make it return 1 in case of
a recoverable error and -1 in case of an unrecoverable error.
Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
To libify `git apply` functionality we have to signal errors to the
caller instead of die()ing.
To do that in a compatible manner with the rest of the error handling
in "builtin/apply.c", try_create_file() should return -1 in case of
error.
Unfortunately try_create_file() currently returns -1 to signal a
recoverable error. To fix that, let's make it return 1 in case of
a recoverable error and -1 in case of an unrecoverable error.
Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/apply.c | diffblobblamehistory |