upload-archive: handle "-h" option early
commit619b6c1710f726866f62e34b01cc57c03b390299
authorJeff King <peff@peff.net>
Tue, 30 May 2017 05:13:43 +0000 (30 01:13 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 30 May 2017 05:45:04 +0000 (30 14:45 +0900)
tree51fdfbb3ea8441b2b479fa7121127262eb6073f3
parent42fa0cbfe02bfb5f3e11d6d04f0205e1650f2e39
upload-archive: handle "-h" option early

Normally upload-archive forks off upload-archive--writer to
do the real work, and relays any errors back over the
sideband channel. This is a good thing when the command is
properly invoked remotely via ssh or git-daemon. But it's
confusing to curious users who try "git upload-archive -h".

Let's catch this invocation early and give a real usage
message, rather than spewing "-h does not appear to be a git
repository" amidst packet-lines. The chance of a false
positive due to a real client asking for the repo "-h" is
quite small.

Likewise, we'll catch "-h" in upload-archive--writer. People
shouldn't be invoking it manually, but it doesn't hurt to
give a sane message if they do.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/upload-archive.c