| commit | 614b19542f649945774a084f2bcf56191f46947c | |
| author | Jeff King <peff@peff.net> | |
| Fri, 24 Mar 2017 17:25:22 +0000 (24 13:25 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 24 Mar 2017 19:34:07 +0000 (24 12:34 -0700) | ||
| tree | bd0d963f1126a22baacda94c821958c5eba16a1a | treesnapshot (tar.gz zip) |
| parent | 296ab786eed237b59f76f6411e895cc1e3ce14ab | commitdiff |
fast-import: use xsnprintf for writing sha1s
When we have to write a sha1 with a newline, we do so by
copying both into a single buffer, so that we can issue a
single write() call.
We use snprintf but don't bother to check the output, since
we know it will fit. However, we should use xsnprintf() in
such a case so that we're notified if our assumption turns
out to be wrong (and to make it easier to audit for
unchecked snprintf calls).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
When we have to write a sha1 with a newline, we do so by
copying both into a single buffer, so that we can issue a
single write() call.
We use snprintf but don't bother to check the output, since
we know it will fit. However, we should use xsnprintf() in
such a case so that we're notified if our assumption turns
out to be wrong (and to make it easier to audit for
unchecked snprintf calls).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| fast-import.c | diffblobblamehistory |