| commit | 5ec711082255d1a580e3270c40ca76d655a3dd7c | |
| author | Yuyi Wang <Strawberry_Str@hotmail.com> | |
| Tue, 24 May 2022 12:57:01 +0000 (24 12:57 +0000) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 24 May 2022 23:06:02 +0000 (24 16:06 -0700) | ||
| tree | 304f4358942800328d86cab0e0b4409a0b9ce905 | treesnapshot (tar.gz zip) |
| parent | 80431510a2b97e08bd577f39934e2b5ea9a43034 | commitdiff |
cmake: remove (_)UNICODE def on Windows in CMakeLists.txt
`UNICODE` and `_UNICODE` are not required when building git on Windows.
Actually, they should not be predefined at all.
There're 2 evidences that `(_)UNICODE` is supposed to be nonexist:
compat/win32/trace2_win32_process_info.c:83: It uses jw_array_string
which accepts pe32.szExeFile as const char*.
t/helper/test-drop-caches.c:16: Calling to GetCurrentDirectory with
Buffer as char*.
The autotools build system never defines `UNICODE` and `_UNICODE` and
builds on Windows well.
Signed-off-by: Yuyi Wang <Strawberry_Str@hotmail.com>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
`UNICODE` and `_UNICODE` are not required when building git on Windows.
Actually, they should not be predefined at all.
There're 2 evidences that `(_)UNICODE` is supposed to be nonexist:
compat/win32/trace2_win32_process_info.c:83: It uses jw_array_string
which accepts pe32.szExeFile as const char*.
t/helper/test-drop-caches.c:16: Calling to GetCurrentDirectory with
Buffer as char*.
The autotools build system never defines `UNICODE` and `_UNICODE` and
builds on Windows well.
Signed-off-by: Yuyi Wang <Strawberry_Str@hotmail.com>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| contrib/buildsystems/CMakeLists.txt | diffblobblamehistory |