| commit | 4b7cc26a74b01ceab14a32ef66704557b26d5622 | |
| author | Jeff King <peff@peff.net> | |
| Sat, 26 May 2007 03:42:36 +0000 (25 23:42 -0400) | ||
| committer | Junio C Hamano <junkio@cox.net> | |
| Sat, 26 May 2007 04:43:33 +0000 (25 21:43 -0700) | ||
| tree | 2719dd1ecc701a0979f440d6b1e9f26e6c590fb4 | treesnapshot (tar.gz zip) |
| parent | c1bab2889eb71bf537497fc77a2fdb6a74bc92e6 | commitdiff |
git-am: use printf instead of echo on user-supplied strings
Under some implementations of echo (such as that provided by
dash), backslash escapes are recognized without any other
options. This means that echo-ing user-supplied strings may
cause any backslash sequences in them to be converted. Using
printf resolves the ambiguity.
This bug can be seen when using git-am to apply a patch
whose subject contains the character sequence "\n"; the
characters are converted to a literal newline. Noticed by
Szekeres Istvan.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Under some implementations of echo (such as that provided by
dash), backslash escapes are recognized without any other
options. This means that echo-ing user-supplied strings may
cause any backslash sequences in them to be converted. Using
printf resolves the ambiguity.
This bug can be seen when using git-am to apply a patch
whose subject contains the character sequence "\n"; the
characters are converted to a literal newline. Noticed by
Szekeres Istvan.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
| git-am.sh | diffblobblamehistory |