| commit | 3ac53e0d13fa7483cce90eb6a1cfcdcbda5b8e35 | |
| author | H. Peter Anvin <hpa@zytor.com> | |
| Tue, 27 Mar 2007 23:45:06 +0000 (27 16:45 -0700) | ||
| committer | Junio C Hamano <junkio@cox.net> | |
| Thu, 29 Mar 2007 08:41:23 +0000 (29 01:41 -0700) | ||
| tree | 42854e6d306ac2ea13bcdcb1f258c77f080a1abf | treesnapshot (tar.gz zip) |
| parent | c2c6d9302a98ae4c4c76822a1c83551c039271a0 | commitdiff |
git-upload-pack: make sure we close unused pipe ends
Right now, we don't close the read end of the pipe when git-upload-pack
runs git-pack-object, so we hang forever (why don't we get SIGALRM?)
instead of dying with SIGPIPE if the latter dies, which seems to be the
norm if the client disconnects.
Thanks to Johannes Schindelin <Johannes.Schindelin@gmx.de> for
pointing out where this close() needed to go.
This patch has been tested on kernel.org for several weeks and appear
to resolve the problem of git-upload-pack processes hanging around
forever.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
(cherry picked from commit 465b3518a9ad5080a4b652ef35fb13c61a93e7a4)
Right now, we don't close the read end of the pipe when git-upload-pack
runs git-pack-object, so we hang forever (why don't we get SIGALRM?)
instead of dying with SIGPIPE if the latter dies, which seems to be the
norm if the client disconnects.
Thanks to Johannes Schindelin <Johannes.Schindelin@gmx.de> for
pointing out where this close() needed to go.
This patch has been tested on kernel.org for several weeks and appear
to resolve the problem of git-upload-pack processes hanging around
forever.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
(cherry picked from commit 465b3518a9ad5080a4b652ef35fb13c61a93e7a4)
| upload-pack.c | diffblobblamehistory |