| commit | 31b49d9b653803e7c7fd18b21c8bdd86e3421668 | |
| author | Jeff King <peff@peff.net> | |
| Fri, 3 Feb 2012 22:14:11 +0000 (3 17:14 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 3 Feb 2012 22:37:02 +0000 (3 14:37 -0800) | ||
| tree | da885e35b5710ea8f100af03ed6c8b75c1905b44 | treesnapshot (tar.gz zip) |
| parent | 828ea97de486c1693d6e4f2c7347acb50235a85d | commitdiff |
prompt: clean up strbuf usage
The do_askpass function inherited a few bad habits from the
original git_getpass. One, there's no need to strbuf_reset a
buffer which was just initialized. And two, it's a good
habit to use strbuf_detach to claim ownership of a buffer's
string (even though in this case the owning buffer goes out
of scope, so it's effectively the same thing).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The do_askpass function inherited a few bad habits from the
original git_getpass. One, there's no need to strbuf_reset a
buffer which was just initialized. And two, it's a good
habit to use strbuf_detach to claim ownership of a buffer's
string (even though in this case the owning buffer goes out
of scope, so it's effectively the same thing).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| prompt.c | diffblobblamehistory |