sha1_file: rename LOOKUP_REPLACE_OBJECT
commit1f0c0d36c1567f5cc8c10141fd4e70b871e809fd
authorJonathan Tan <jonathantanmy@google.com>
Thu, 22 Jun 2017 00:40:19 +0000 (21 17:40 -0700)
committerJunio C Hamano <gitster@pobox.com>
Thu, 22 Jun 2017 01:54:43 +0000 (21 18:54 -0700)
tree52578a8e2d741619cf5513f6ba8eb643b207ea84
parent19fc5e84a70e0dc6d6b3a279fa549b4e522ee33b
sha1_file: rename LOOKUP_REPLACE_OBJECT

The LOOKUP_REPLACE_OBJECT flag controls whether the
lookup_replace_object() function is invoked by
sha1_object_info_extended(), read_sha1_file_extended(), and
lookup_replace_object_extended(), but it is not immediately clear which
functions accept that flag.

Therefore restrict this flag to only sha1_object_info_extended(),
renaming it appropriately to OBJECT_INFO_LOOKUP_REPLACE and adding some
documentation. Update read_sha1_file_extended() to have a boolean
parameter instead, and delete lookup_replace_object_extended().

parse_sha1_header() also passes this flag to
parse_sha1_header_extended() since commit 46f0344 ("sha1_file: support
reading from a loose object of unknown type", 2015-05-03), but that has
had no effect since that commit. Therefore this patch also removes this
flag from that invocation.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/cat-file.c
cache.h
sha1_file.c