| commit | 1cae428e2902b3f19a56625411f09cc239855fe7 | |
| author | Jeff King <peff@peff.net> | |
| Sat, 9 Apr 2016 17:43:54 +0000 (9 13:43 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sun, 10 Apr 2016 18:14:59 +0000 (10 11:14 -0700) | ||
| tree | 1bc5d010b78e12c137515770ec73892f4ffde2c3 | treesnapshot (tar.gz zip) |
| parent | 9c14bb08a434570adc9b2f0f37eac66b92d4c87e | commitdiff |
git_config_set_multivar_in_file: handle "unset" errors
We pass off to the "_gently" form to do the real work, and
just die() if it returned an error. However, our die message
de-references "value", which may be NULL if the request was
to unset a variable. Nobody using glibc noticed, because it
simply prints "(null)", which is good enough for the test
suite (and presumably very few people run across this in
practice). But other libc implementations (like Solaris) may
segfault.
Let's not only fix that, but let's make the message more
clear about what is going on in the "unset" case.
Reported-by: "Tom G. Christensen" <tgc@jupiterrise.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
We pass off to the "_gently" form to do the real work, and
just die() if it returned an error. However, our die message
de-references "value", which may be NULL if the request was
to unset a variable. Nobody using glibc noticed, because it
simply prints "(null)", which is good enough for the test
suite (and presumably very few people run across this in
practice). But other libc implementations (like Solaris) may
segfault.
Let's not only fix that, but let's make the message more
clear about what is going on in the "unset" case.
Reported-by: "Tom G. Christensen" <tgc@jupiterrise.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| config.c | diffblobblamehistory |