-Wuninitialized: remove some 'init-self' workarounds
commit156e1782a88d882faf66680b5155a1c140e86a56
authorRamsay Jones <ramsay@ramsayjones.plus.com>
Mon, 19 Mar 2018 17:54:35 +0000 (19 17:54 +0000)
committerJunio C Hamano <gitster@pobox.com>
Tue, 20 Mar 2018 16:59:21 +0000 (20 09:59 -0700)
treeba225fcf23d0ea18a05bfe7a786fd145210d0a4f
parent38e79b1fdab9244e1727d0698afcf3bb8956c0a4
-Wuninitialized: remove some 'init-self' workarounds

The 'self-initialised' variables construct (ie <type> var = var;) has
been used to silence gcc '-W[maybe-]uninitialized' warnings. This has,
unfortunately, caused MSVC to issue 'uninitialized variable' warnings.
Also, using clang static analysis causes complaints about an 'Assigned
value is garbage or undefined'.

There are six such constructs in the current codebase. Only one of the
six causes gcc to issue a '-Wmaybe-uninitialized' warning (which will
be addressed elsewhere). The remaining five 'init-self' gcc workarounds
are noted below, along with the commit which introduced them:

  1. builtin/rev-list.c: 'reaches' and 'all', see commit 457f08a030
     ("git-rev-list: add --bisect-vars option.", 2007-03-21).

  2. merge-recursive.c:2064 'mrtree', see commit f120ae2a8e ("merge-
     recursive.c: mrtree in merge() is not used before set", 2007-10-29).

  3. fast-import.c:3023 'oe', see commit 85c62395b1 ("fast-import: let
     importers retrieve blobs", 2010-11-28).

  4. fast-import.c:3006 'oe', see commit 28c7b1f7b7 ("fast-import: add a
     get-mark command", 2015-07-01).

Remove the 'self-initialised' variable constructs noted above.

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/rev-list.c
fast-import.c
merge-recursive.c