From 363c4ade52b36a986b2e7bd35563459d8fd49485 Mon Sep 17 00:00:00 2001 From: Michael Adam Date: Tue, 5 Nov 2013 18:10:25 +0100 Subject: [PATCH] s4:torture:smb2: add comment explaining lease upgrade in the non-contended case The summary of the behaviour is this: ------------------------------------- An uncontended lease upgrade results in a change if and only if the requested lease state is - valid, and - strictly a superset of the lease state already held. In that case the resulting lease state is the one requested in the upgrade. Signed-off-by: Michael Adam Reviewed-by: David Disseldorp --- source4/torture/smb2/lease.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/source4/torture/smb2/lease.c b/source4/torture/smb2/lease.c index 992c21b2406..651fe26b153 100644 --- a/source4/torture/smb2/lease.c +++ b/source4/torture/smb2/lease.c @@ -262,6 +262,17 @@ static bool test_lease_upgrade(struct torture_context *tctx, /** * upgrade2 test. * full matrix of lease upgrade combinations + * (non-contended case) + * + * The summary of the behaviour is this: + * ------------------------------------- + * An uncontended lease upgrade results in a change + * if and only if the requested lease state is + * - valid, and + * - strictly a superset of the lease state already held. + * + * In that case the resulting lease state is the one + * requested in the upgrade. */ struct lease_upgrade2_test { const char *initial; -- 2.11.4.GIT