From a3b4a5d7793b208436e541f2382c96c35fa31089 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 8 Jun 2012 14:29:41 +0200 Subject: [PATCH] s3: Assigning ?True:False to a bool is a bit pointless Signed-off-by: Michael Adam --- source3/smbd/open.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/source3/smbd/open.c b/source3/smbd/open.c index a098124618b..d5fba4db192 100644 --- a/source3/smbd/open.c +++ b/source3/smbd/open.c @@ -776,12 +776,11 @@ static NTSTATUS open_file(files_struct *fsp, fsp->vuid = req ? req->vuid : UID_FIELD_INVALID; fsp->file_pid = req ? req->smbpid : 0; fsp->can_lock = True; - fsp->can_read = (access_mask & FILE_READ_DATA) ? True : False; + fsp->can_read = ((access_mask & FILE_READ_DATA) != 0); if (!CAN_WRITE(conn)) { fsp->can_write = False; } else { - fsp->can_write = (access_mask & (FILE_WRITE_DATA | FILE_APPEND_DATA)) ? - True : False; + fsp->can_write = ((access_mask & (FILE_WRITE_DATA | FILE_APPEND_DATA)) != 0); } fsp->print_file = NULL; fsp->modified = False; -- 2.11.4.GIT