From 76e86e88c3d578ad47d4bc9ef7e8e6c035715dea Mon Sep 17 00:00:00 2001 From: Richard Sharpe Date: Tue, 16 Mar 2004 06:56:20 +0000 Subject: [PATCH] Make sure we don't clobber the stack when response consists of the empty string. (This used to be commit e522663717f6b6141580f34502ad8686d326f8c8) --- source3/nsswitch/winbindd_wins.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/source3/nsswitch/winbindd_wins.c b/source3/nsswitch/winbindd_wins.c index bc982d00443..a1eef159c0a 100644 --- a/source3/nsswitch/winbindd_wins.c +++ b/source3/nsswitch/winbindd_wins.c @@ -201,7 +201,10 @@ enum winbindd_result winbindd_wins_byname(struct winbindd_cli_state *state) } if (i != 0) { /* Clear out the newline character */ - response[strlen(response)-1] = ' '; + /* But only if there is something in there, + otherwise we clobber something in the stack */ + if (strlen(response)) + response[strlen(response)-1] = ' '; } fstrcat(response,addr); fstrcat(response,"\t"); -- 2.11.4.GIT