From 3101fcccff3ef847a123b10b2b99611e52504414 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Fri, 30 Nov 2012 09:31:34 +0100 Subject: [PATCH] s3:util: fix usage of popt_burn_cmdline_password() We should only call popt_burn_cmdline_password() after poptFreeContext(), otherwise we remove the password to early. Signed-off-by: Stefan Metzmacher Reviewed-by: Andreas Schneider --- source3/utils/smbcacls.c | 1 - source3/utils/smbcquotas.c | 1 - 2 files changed, 2 deletions(-) diff --git a/source3/utils/smbcacls.c b/source3/utils/smbcacls.c index d22e2f3bac0..da190ddda17 100644 --- a/source3/utils/smbcacls.c +++ b/source3/utils/smbcacls.c @@ -1371,7 +1371,6 @@ static struct cli_state *connect_one(struct user_auth_info *auth_info, popt_common_set_auth_info(auth_info); pc = poptGetContext("smbcacls", argc, argv, long_options, 0); - popt_burn_cmdline_password(argc, argv); poptSetOtherOptionHelp(pc, "//server1/share1 filename\nACLs look like: " "'ACL:user:[ALLOWED|DENIED]/flags/permissions'"); diff --git a/source3/utils/smbcquotas.c b/source3/utils/smbcquotas.c index d248bbe1ebf..7363d6b4a30 100644 --- a/source3/utils/smbcquotas.c +++ b/source3/utils/smbcquotas.c @@ -608,7 +608,6 @@ FSQFLAGS:QUOTA_ENABLED/DENY_DISK/LOG_SOFTLIMIT/LOG_HARD_LIMIT", "SETSTRING" }, popt_common_set_auth_info(smbcquotas_auth_info); pc = poptGetContext("smbcquotas", argc, argv, long_options, 0); - popt_burn_cmdline_password(argc, argv); poptSetOtherOptionHelp(pc, "//server1/share1"); -- 2.11.4.GIT