From 8f0bdb9c4ede5e953904cfc528c57886f9de2bdb Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Wed, 8 Mar 2006 07:20:11 +0000 Subject: [PATCH] r14030: Fix resource leak in error codepath. Coverity CID #64. Jeremy. (This used to be commit b51edde4d63e9b2f241f41b6780b026487890a7f) --- source3/tdb/tdb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/source3/tdb/tdb.c b/source3/tdb/tdb.c index f07f474716f..4303976087d 100644 --- a/source3/tdb/tdb.c +++ b/source3/tdb/tdb.c @@ -1458,10 +1458,14 @@ TDB_DATA tdb_nextkey(TDB_CONTEXT *tdb, TDB_DATA oldkey) rec.key_len)) || memcmp(k, oldkey.dptr, oldkey.dsize) != 0) { /* No, it wasn't: unlock it and start from scratch */ - if (unlock_record(tdb, tdb->travlocks.off) != 0) + if (unlock_record(tdb, tdb->travlocks.off) != 0) { + SAFE_FREE(k); return tdb_null; - if (tdb_unlock(tdb, tdb->travlocks.hash, F_WRLCK) != 0) + } + if (tdb_unlock(tdb, tdb->travlocks.hash, F_WRLCK) != 0) { + SAFE_FREE(k); return tdb_null; + } tdb->travlocks.off = 0; } -- 2.11.4.GIT