| commit | 2615b079f04903a80e02334a78961a54f915d063 | |
| author | Jeremy Allison <jra@samba.org> | |
| Tue, 7 Mar 2006 19:18:56 +0000 (7 19:18 +0000) | ||
| committer | Gerald (Jerry) Carter <jerry@samba.org> | |
| Wed, 10 Oct 2007 16:11:02 +0000 (10 11:11 -0500) | ||
| tree | 009817345d9123340d371754032ad5b4c04aaee6 | treesnapshot (tar.gz zip) |
| parent | 71272fc441d7930f7ae810ee3c8f5a58385cb55c | commitdiff |
r13978: Here is why it's essential to use SAFE_FREE instead of free.
If we use free(data.dptr) and then the subsequent tdb_open
fails in _reg_perfcount_get_counter_data() then data.dptr
is left as a non-zero pointer that has been freed. This would
cause it to be reused later on. Coverity bug #162.
Jeremy.
(This used to be commit 053efc20981e0280c6af0ebb9e17cea07da85fe8)
If we use free(data.dptr) and then the subsequent tdb_open
fails in _reg_perfcount_get_counter_data() then data.dptr
is left as a non-zero pointer that has been freed. This would
cause it to be reused later on. Coverity bug #162.
Jeremy.
(This used to be commit 053efc20981e0280c6af0ebb9e17cea07da85fe8)
| source3/registry/reg_perfcount.c | diffblobblamehistory |