From f258e98e177f0f75bab99654b9f32b10bb7ce37f Mon Sep 17 00:00:00 2001 From: =?utf8?q?G=C3=BCnther=20Deschner?= Date: Fri, 5 Mar 2010 21:56:50 +0100 Subject: [PATCH] winreg: fix winreg_QueryValue IDL. Note that before this change pidl generated code that just dereferenced size_is and length_is values from unique pointers without checking whether these pointers were actually NULL. With this change, pidl now throws a warning like: warning: Got pointer for `data_size', expected fully derefenced variable which is not correct, probably because pidl does not evaluate the C expression. Guenther --- librpc/idl/winreg.idl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/librpc/idl/winreg.idl b/librpc/idl/winreg.idl index f1f4dfb719e..70206916e02 100644 --- a/librpc/idl/winreg.idl +++ b/librpc/idl/winreg.idl @@ -256,7 +256,7 @@ import "lsa.idl", "security.idl", "misc.idl"; [in,ref] policy_handle *handle, [in,ref] winreg_String *value_name, [in,out,unique] winreg_Type *type, - [in,out,unique,size_is(*data_size),length_is(*data_length)] uint8 *data, + [in,out,unique,size_is(data_size ? *data_size : 0),length_is(data_length ? *data_length : 0),range(0,0x4000000)] uint8 *data, [in,out,unique] uint32 *data_size, [in,out,unique] uint32 *data_length ); -- 2.11.4.GIT